Fix modals in Edge. #12241
Merged
Fix modals in Edge. #12241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes #11585. Edge has a buggy implementation of `position: sticky;`, which includes issues with flickering, z-index, and parent container paddings. See more at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17555420/. This is mainly an issue in deeply nested elements, it seems. This PR includes an edge only hack that overrides the sticky and uses `position: fixed;` instead.
jasmussen
added
[Type] Bug
tofumatt
reviewed
Nov 23, 2018
| @@ -66,13 +66,20 @@ | |||
| justify-content: space-between; | |||
| background: $white; | |||
| align-items: center; | |||
| box-sizing: border-box; | |||
There was a problem hiding this comment.
Was this just not needed anymore? It doesn’t seem related to the other changes.
There was a problem hiding this comment.
Yes, good catch, I should've noted that as a code comment. Turns out that rule was written out twice in the same rule. Here it is on line 61, still there:
Thank you for the review.
4 tasks
youknowriad
pushed a commit
that referenced
this pull request
Nov 29, 2018
This PR fixes #11585. Edge has a buggy implementation of `position: sticky;`, which includes issues with flickering, z-index, and parent container paddings. See more at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17555420/. This is mainly an issue in deeply nested elements, it seems. This PR includes an edge only hack that overrides the sticky and uses `position: fixed;` instead.
This was referenced Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11585.
Edge has a buggy implementation of
position: sticky;, which includes issues with flickering, z-index, and parent container paddings. See more at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17555420/.This is mainly an issue in deeply nested elements, it seems.
This PR includes an edge only hack that overrides the sticky and uses
position: fixed;instead.JIFs, Edge:
IE 11:
Chrome, Mac:
Safari, Mac:
Firefox, Mac: